Messages in this thread | | | Date | Tue, 28 May 2013 10:10:53 +0200 | From | Johannes Thumshirn <> | Subject | Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs |
| |
On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: [...] > > + watchdog_set_drvdata(&a21_wdt, drv); > > I am missing the initialisation of the watchdog's timeout value here...
This watchdog only knows two timeout values, 1s and 30s with the constraint that you can't go back to 30s once your in a 1s timeout without a reset of the CPLD. I could initially set it to 30s but that would be redundant.
> For the rest this looks OK. > > Kind regards, > wim. >
This sounds pretty good.
| |