Messages in this thread | | | Date | Tue, 28 May 2013 19:14:36 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: Fix adjust_range_size_mask calling position |
| |
On 05/28/2013 04:43 PM, Yinghai Lu wrote: >> >> Sorry, I'm not sure I understand what the above paragraph is trying to say. > > We merge the continuous range with same page size allow too early. > in the case > [mem 0x00200000-0x3fffffff] page 2M > [mem 0x40000000-0x7bffffff] page 2M > after merging them, will get > [mem 0x00200000-0x7bffffff] page 2M > even we can use 1G page to map > [mem 0x40000000-0x7bffffff] > > that will cause problem, because we map > [mem 0x7fe00000-0x7fffffff] page 1G > [mem 0x7c000000-0x7fdfffff] page 1G > with 1G page. > > so need to adjust page size at first before merge > [mem 0x00200000-0x3fffffff] page 2M > [mem 0x40000000-0x7bffffff] page 2M >
What I meant with that is please update the description so someone uninitiated can follow the description, either now or in 5-10 years.
-hpa
| |