lkml.org 
[lkml]   [2013]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets
    From
    Date
    On Tue, 2013-05-28 at 09:00 -0700, Ben Greear wrote:
    > On 05/27/2013 03:41 PM, Francois Romieu wrote:
    > > atomlin@redhat.com <atomlin@redhat.com> :
    > > [...]
    > >> Failed GFP_ATOMIC allocations by the network stack result in dropped
    > >> packets, which will be received on a subsequent retransmit, and an
    > >> unnecessary, noisy warning with a kernel backtrace.
    []
    > > Please don't paper over it just because some shit ends in your backyard.
    > We should rate-limit these messages at least.

    Already done.
    Look in mm/page_alloc:warn_alloc_failed()

    void warn_alloc_failed(gfp_t gfp_mask, int order, const char *fmt, ...)
    {
    unsigned int filter = SHOW_MEM_FILTER_NODES;

    if ((gfp_mask & __GFP_NOWARN) || !__ratelimit(&nopage_rs) ||
    debug_guardpage_minorder() > 0)
    return;




    \
     
     \ /
      Last update: 2013-05-28 20:01    [W:7.345 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site