Messages in this thread | | | Date | Mon, 27 May 2013 13:39:11 -0400 | From | Rik van Riel <> | Subject | Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets |
| |
On 05/26/2013 04:19 PM, atomlin@redhat.com wrote: > From: Aaron Tomlin <atomlin@redhat.com> > > Since v1: > - Removed unnecessary parentheses > > ---8<--- > > Failed GFP_ATOMIC allocations by the network stack result in dropped > packets, which will be received on a subsequent retransmit, and an > unnecessary, noisy warning with a kernel backtrace. > > These warnings are harmless, but they still cause users to panic and > file bug reports over dropped packets. It would be better to hide the > failed allocation warnings and backtraces, and let retransmits handle > dropped packets quietly.
Yes please. Getting memory management bug reports for dropped network packets got old years ago. Lets get rid of those messages.
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
| |