lkml.org 
[lkml]   [2013]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once
On 27-05-2013 14:19, Sergei Shtylyov wrote:

>> When booting a new board for the first time, the console is flooded with
>> "Unknown board" messages. This is not really helpful. Board type is not
>> going to change after the boot, so it's sufficient to print the warning
>> only once.

>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>> ---
>> arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)

>> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
>> b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
>> index 7c64977..e0451a0 100644
>> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
>> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> [...]
>> @@ -184,8 +186,7 @@ int cvmx_helper_board_get_mii_address(int ipd_port)
>> }
>>
>> /* Some unknown board. Somebody forgot to update this
>> function... */
>> - cvmx_dprintf
>> - ("cvmx_helper_board_get_mii_address: Unknown board type %d\n",
>> + pr_warn_once("%s: Unknown board type %d\n", __func__,
>> cvmx_sysinfo_get()->board_type);

> Please align this line under the next char under (.

s/under (/after (/, of course.

WBR, Sergei



\
 
 \ /
  Last update: 2013-05-27 20:01    [W:0.046 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site