Messages in this thread | | | Date | Mon, 27 May 2013 09:06:35 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH] arch: x86: platform: mrst: pr_err() need notice that 'sdev->modalias' may not a NUL terminated string. |
| |
On Sun, May 26, 2013 at 04:50:22PM +0800, Chen Gang wrote: > > According to the areas which use "%16.16s" within this file, the > 'sdev->modalias' may not always be a NUL terminated string. > > So need use "%.16s" instead of "%s" in pr_err(), or may cause issue.
No. spi_match_id() expects a NULL terminated string and I would be suprised if it would be otherwise. Therefore moorsetown or this files has to learn to NULL terminate its strings.
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Sebastian
| |