lkml.org 
[lkml]   [2013]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch: x86: platform: mrst: pr_err() need notice that 'sdev->modalias' may not a NUL terminated string.
On Sun, May 26, 2013 at 04:50:22PM +0800, Chen Gang wrote:
>
> According to the areas which use "%16.16s" within this file, the
> 'sdev->modalias' may not always be a NUL terminated string.
>
> So need use "%.16s" instead of "%s" in pr_err(), or may cause issue.

No. spi_match_id() expects a NULL terminated string and I would be suprised if
it would be otherwise. Therefore moorsetown or this files has to learn to NULL
terminate its strings.

> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Sebastian


\
 
 \ /
  Last update: 2013-05-27 09:41    [W:0.028 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site