Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 02/14] misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io | Date | Mon, 27 May 2013 17:18:41 +0200 |
| |
On Saturday 25 May 2013, H Hartley Sweeten wrote: > @@ -42,13 +42,13 @@ struct ep93xx_pwm { > static inline void ep93xx_pwm_writel(struct ep93xx_pwm *pwm, > unsigned int val, unsigned int off) > { > - __raw_writel(val, pwm->mmio_base + off); > + writel(val, pwm->mmio_base + off); > }
Just an idea: since you are adding the writel in a lot of places in subsequent patches, you could rename 'mmio_base' to the shorter 'base' first, which would make the resulting code actually smaller.
Arnd
| |