Messages in this thread | | | Date | Mon, 27 May 2013 11:52:00 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver |
| |
On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote: > On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: >>> Hi Kishon, >>> >>> I have some comment about this patch >>> and upload modified patch to following repository (extcon-for-palmas). >>> - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmas&id=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c >>> >>> This patchset include patch related to other module >>> ,so I need your opinion to apply this patchset to git repository. >> yeah.. Still there is some confusion with palmas_set_switch_smps10(). I think we can remove it for now and add it separately later. By this at least we can have device mode fully functional in OMAP5. What do you think? >> > I agree your opinion. > > But, I propose some fixes about palmas_set_switch_smps10(). > I dont' prefer to call global function in exton-palmas.c from palmas-regulator.c. > So, Why don't you use regulator consumer instead of global function? > You can register specific regulator for enabling or disabling SMPS10_SWITCH_EN > and then control SMPS10_SWITCH_EN bit through regulator framework in extcon-palmas.c > without calling global function.
Along with this, I also like to make the VBUS regulator control to be optional here. Currently it is mandatory.
| |