Messages in this thread | | | Date | Mon, 27 May 2013 15:32:07 +0530 | From | Anshuman Khandual <> | Subject | Re: [PATCH 1/2] powerpc, perf: Ignore separate BHRB privilege state filter request |
| |
On 05/22/2013 02:29 PM, Anshuman Khandual wrote: >> >> Your description from patch 0 should be here. > Does it sound better ? > >> >>> - if ((br_privilege != 7) && (br_privilege != 0)) >>> - return -1; >>> + >>> + if (br_privilege) >>> + pr_info("BHRB privilege state filter request %llx ignored\n", >>> + br_privilege); >> >> Don't do that. Ignoring the br_privilege is either the right thing to do >> in which case we do it and print nothing, > > > I thought the informational print would at least make the user aware > of the fact that the separate filter request for BHRB went ignored. > Can we add this some where in the documentation ?
So, what we decide here ? We will just ignore any separate BHRB privilege state filter request without printing any informational event or warning ?
| |