Messages in this thread | | | Date | Fri, 24 May 2013 07:59:07 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 3/5] watchdog: da9055: use platform_{get,set}_drvdata() |
| |
On Thu, May 23, 2013 at 07:44:23PM +0900, Jingoo Han wrote: > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/da9055_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.c > index f5ad105..575f37a 100644 > --- a/drivers/watchdog/da9055_wdt.c > +++ b/drivers/watchdog/da9055_wdt.c > @@ -174,7 +174,7 @@ static int da9055_wdt_probe(struct platform_device *pdev) > goto err; > } > > - dev_set_drvdata(&pdev->dev, driver_data); > + platform_set_drvdata(pdev, driver_data); > > ret = watchdog_register_device(&driver_data->wdt); > if (ret != 0) > @@ -187,7 +187,7 @@ err: > > static int da9055_wdt_remove(struct platform_device *pdev) > { > - struct da9055_wdt_data *driver_data = dev_get_drvdata(&pdev->dev); > + struct da9055_wdt_data *driver_data = platform_get_drvdata(pdev); > > watchdog_unregister_device(&driver_data->wdt); > kref_put(&driver_data->kref, da9055_wdt_release_resources); > -- > 1.7.10.4 > > >
| |