lkml.org 
[lkml]   [2013]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usbfs: Increase arbitrary limit for USB 3 isopkt length
Hello.

On 24-05-2013 12:47, Federico Manzan wrote:

> Increase the current arbitrary limit for isocronous packet size to a
> value large enough to account for USB 3.0 super bandwidth streams,
> bMaxBurst (0~15 allowed, 1~16 packets)
> bmAttributes (bit 1:0, mult 0~2, 1~3 packets)
> so the size max for one USB 3 isocronous transfer is
> 1024 byte * 16 * 3 = 49152 byte

> Signed-off-by: Federico Manzan <f.manzan@gmail.com>
> ---
> drivers/usb/core/devio.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)

> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index caefc80..7ac137e 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -1287,9 +1287,11 @@ static int proc_do_submiturb(struct dev_state *ps, struct usbdevfs_urb *uurb,
> goto error;
> }
> for (totlen = u = 0; u < uurb->number_of_packets; u++) {
> - /* arbitrary limit,
> - * sufficient for USB 2.0 high-bandwidth iso */
> - if (isopkt[u].length > 8192) {
> + /* arbitrary limit need for USB 3.0
> + * bMaxBurst (0~15 allowed, 1~16 packets)
> + * bmAttributes (bit 1:0, mult 0~2, 1~3 packets)
> + * sizemax: 1024 * 16 * 3 = 49152*/

The preferred style of the multi-line comments is this:

/*
* bla
* bla
*/

WBR, Sergei



\
 
 \ /
  Last update: 2013-05-24 17:21    [W:0.100 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site