Messages in this thread | | | Date | Thu, 23 May 2013 08:49:13 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv4 07/39] thp, mm: basic defines for transparent huge page cache |
| |
On 05/23/2013 03:36 AM, Hillf Danton wrote: > On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov > <kirill.shutemov@linux.intel.com> wrote: >> > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Better if one or two sentences are prepared to show that the following > defines are necessary. ... >> > >> > +#define HPAGE_CACHE_ORDER (HPAGE_SHIFT - PAGE_CACHE_SHIFT) >> > +#define HPAGE_CACHE_NR (1L << HPAGE_CACHE_ORDER) >> > +#define HPAGE_CACHE_INDEX_MASK (HPAGE_CACHE_NR - 1)
Yeah, or just stick them in the patch that uses them first. These aren't exactly rocket science.
| |