lkml.org 
[lkml]   [2013]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [ANNOUNCE] ktap 0.1 released
From
On Wed, May 22, 2013 at 12:19 PM, Ming Lei <tom.leiming@gmail.com> wrote:
> On Wed, May 22, 2013 at 12:15 PM, Ming Lei <tom.leiming@gmail.com> wrote:
>> On Tue, May 21, 2013 at 11:56 AM, zhangwei(Jovi)
>>
>> Nice job, I have run it on ARM already with only one line change.
>>
>> But looks 'Control-C' can't stop the tracing or need some time to complete it,
>> see below:
>
> Sometimes, it doesn't work:
>
> $ sudo ./ktap ./scripts/kretprobe.kp
> ......
> vfs_read! (execname sshd); retval:38
> ^Cvfs_read! (execname sshd); retval:38
>
> probe ending
> vfs_read! (execname sshd); retval:48
> vfs_read! (execname sshd); retval:2
> ^C
> ^C^C^C
> ^C^C^C^C^C^C^C
>
> ^C^C^C^C^C^C

This one can be fixed by below patch, but can't work on
the last one.

diff --git a/vm.c b/vm.c
index c5f5733..a24a389 100644
--- a/vm.c
+++ b/vm.c
@@ -1060,7 +1060,7 @@ ktap_State *kp_newthread(ktap_State *mainthread)

void kp_user_complete(ktap_State *ks)
{
- if (!ks || !G(ks)->user_completion)
+ if (!ks || !G(ks) || !G(ks)->user_completion)
return;

complete(G(ks)->user_completion);


Thanks,
--
Ming Lei


\
 
 \ /
  Last update: 2013-05-22 07:21    [W:0.037 / U:2.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site