Messages in this thread | | | Date | Wed, 22 May 2013 18:08:18 +0200 | From | Florian Meier <> | Subject | Re: [PATCH] ASoC: Add support for BCM2708 |
| |
On 22.05.2013 17:22, Stephen Warren wrote: > On 05/22/2013 08:10 AM, Florian Meier wrote: >> This driver adds support for digital audio (I2S) >> for the BCM2708 SoC that is used by the >> Raspberry Pi. External audio codecs can be >> connected to the Raspberry Pi via P5 header. >> >> It relies on cyclic DMA engine support for BCM2708 >> that is not included in this patch. > > This SoC is actually the BCM2835, so the files should be named for that.
Actually, I changed the name several times and in the end I sticked to https://github.com/raspberrypi/linux/issues/22 but if you think it is better to use BCM2835 I am happy to agree with you and change it.
> Upstream only uses device tree for BCM2835. Does this driver support DT? > Where is the DT binding definition file?
I have not accomplished to use the mainline kernel and DT with the Raspberry Pi. Do you have any introductive information about how to do this?
> I assume you're planning on sending the DMA driver upstream too? I guess > this driver isn't useful without it.
I would like to, but it only supports cyclic DMA. Should I send it upstream anyway? In case you are interested:
https://github.com/koalo/linux/blob/rpi-3.8.y-asocdev/drivers/dma/bcm2708-dmaengine.c
> I'll take a look at the actual patch content later.
That would be great!
| |