This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Sat May 18 08:10:45 2024 Envelope-to: j@jasper.es Delivery-date: Wed, 22 May 2013 05:01:55 +0200 Received: from localhost ([127.0.0.1] helo=squeeze.vs19.net) by squeeze.vs19.net with esmtp (Exim 4.72) (envelope-from ) id 1UezJL-00051p-Rw for j@jasper.es; Wed, 22 May 2013 05:01:55 +0200 Original-Recipient: rfc822;jasper@telfort.nl Received: from pop3.telfort.nl [213.75.3.52] by squeeze.vs19.net with POP3 (fetchmail-6.3.18) for (single-drop); Wed, 22 May 2013 05:01:55 +0200 (CEST) Received: from cpxmta-msg08.kpnxchange.com (10.94.114.29) by cpxmbs-msg01.support.local (8.6.060.17) id 516DA660006843F3 for jasper@telfort.nl; Wed, 22 May 2013 04:56:31 +0200 Received: from cpsmtpb-ews05.kpnxchange.com (213.75.39.8) by cpxmta-msg08.kpnxchange.com (8.6.060.14) id 5192D212001F0584 for jasper@telfort.nl; Wed, 22 May 2013 04:56:31 +0200 Received: from cpsps-ews17.kpnxchange.com ([10.94.84.183]) by cpsmtpb-ews05.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Wed, 22 May 2013 04:56:31 +0200 Received: from vger.kernel.org ([209.132.180.67]) by cpsps-ews17.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Wed, 22 May 2013 04:56:30 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190Ab3EVC4R (ORCPT ); Tue, 21 May 2013 22:56:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754311Ab3EVC4O convert rfc822-to-8bit (ORCPT ); Tue, 21 May 2013 22:56:14 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4M2u8aK024630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 21 May 2013 22 Received: from gelk.kernelslacker.org ([10.3.113.18]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4M2u708007802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 21 May 2013 22:56:08 -0400 Received: from gelk.kernelslacker.org (localhost [127.0.0.1]) by gelk.kernelslacker.org (8.14.7/8.14.5) with ESMTP id r4M2u6Lb030633; Tue, 21 May 2013 22:56:06 -0400 Received: (from davej@localhost) by gelk.kernelslacker.org (8.14.7/8.14.7/Submit) id r4M2u5m3030632; Tue, 21 May 2013 22:56:05 -0400 X-Authentication-Warning: gelk.kernelslacker.org: davej set sender to davej@redhat.com using -f Date: Tue, 21 May 2013 22:56:05 -0400 From: Dave Jones To: Dave Chinner Cc: Linux Kernel , xfs@oss.sgi.com Subject: Re: XFS assertion from truncate. (3.10-rc2) Message-Id: <20130522025605.GA29767@redhat.com> Mail-Followup-To: Dave Jones , Dave Chinner , Linux Kernel , xfs@oss.sgi.com References: <20130521225257.GA12713@redhat.com> <20130521233429.GW29466@dastard> <20130521234016.GB14347@redhat.com> <20130521235410.GY29466@dastard> <20130522000803.GA19891@redhat.com> <20130522001603.GZ29466@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20130522001603.GZ29466@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-OriginalArrivalTime: 22 May 2013 02:56:30.0907 (UTC) FILETIME=[F616E8B0:01CE5697] X-RcptDomain: telfort.nl On Wed, May 22, 2013 at 10:16:03AM +1000, Dave Chinner wrote: Seems like I can trigger this from paths other than truncate too.. (eg, sys_open) Here's what I ended up with for debug diff --git a/fs/dcache.c b/fs/dcache.c index 2b39d16..b579dfe 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -2792,6 +2792,7 @@ char *dentry_path(struct dentry *dentry, char *buf, int buflen) Elong: return ERR_PTR(-ENAMETOOLONG); } +EXPORT_SYMBOL(dentry_path); /* * NOTE! The user-level library version returns a diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index d82efaa..8419e63 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -47,6 +47,7 @@ #include #include #include +#include static int xfs_initxattrs( @@ -714,9 +715,20 @@ xfs_setattr_size( return XFS_ERROR(error); ASSERT(S_ISREG(ip->i_d.di_mode)); - ASSERT((mask & (ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET| + if ((mask & (ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET| ATTR_MTIME_SET|ATTR_KILL_SUID|ATTR_KILL_SGID| - ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0); + ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0) { + + struct dentry *dentry = d_find_any_alias(VFS_I(ip)); + char buf[MAXPATHLEN]; + + dentry_path(dentry, buf, MAXPATHLEN); + dput(dentry); + xfs_warn(mp, "%s: mask 0x%x mismatch on file %s\n", + __func__, mask, buf); + + ASSERT(0); + } if (!(flags & XFS_ATTR_NOLOCK)) { lock_flags |= XFS_IOLOCK_EXCL; Something isn't right though I think.. Because the filenames it outputs look like crap. [ 71.406552] XFS (sda2): xfs_setattr_size: mask 0xa068 mismatch on file 0\xffffffee<\xffffff88\xffffffff\xffffffff\xffffff80O\xffffff82\xffffffff\xffffffff\xffffffff\xffffffff The mask is always 0xa068 though if that helps. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/