Messages in this thread Patch in this message | | | From | Mark Brown <> | Date | Tue, 21 May 2013 13:13:17 -0500 | Subject | [PATCH 3/7] mfd: arizona: Add missing cleanup on remove |
| |
We'd forgotten to disable /RESET or the regulators. Practically speaking this code is unlikely to ever be run.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- drivers/mfd/arizona-core.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 25bfd1e..8002e2d 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -839,6 +839,11 @@ int arizona_dev_exit(struct arizona *arizona) arizona_free_irq(arizona, ARIZONA_IRQ_CLKGEN_ERR, arizona); pm_runtime_disable(arizona->dev); arizona_irq_exit(arizona); + if (arizona->pdata.reset) + gpio_set_value_cansleep(arizona->pdata.reset, 0); + regulator_disable(arizona->dcvdd); + regulator_bulk_disable(ARRAY_SIZE(arizona->core_supplies), + arizona->core_supplies); return 0; } EXPORT_SYMBOL_GPL(arizona_dev_exit); -- 1.7.10.4
| |