Messages in this thread | | | Date | Tue, 21 May 2013 13:45:01 -0400 | From | Peter Hurley <> | Subject | Re: [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console |
| |
On 05/21/2013 12:29 PM, Wang YanQing wrote: > On Wed, May 22, 2013 at 12:18:49AM +0800, Wang YanQing wrote: >>> Except now you're spreading the brokenness that is console_lock() >>> over many more source files than the single-use case of >>> do_take_over_console(). >> >>> The actual interface is take_over_console(); the _workaround_ is >>> exposing do_take_over_console() for fbcon to wrap. >> >> This _workaround_ willn't work, take_over_console will hold console_lock internal, >> but do_take_over_console need caller hold console_lock, then we can't rewrite >> do_take_over_console as a wrap base on take_over_console.
The workaround I'm referring to is commit 50e244cc793 which exposed do_take_over_console() as an interface to band aid the lock problems.
I'm ok with take_over_console() being a lock wrapper around do_take_over_console(), if you are trying to preserve your other changes.
Regards, Peter Hurley
| |