Messages in this thread | | | Subject | Re: [PATCH] rcu: fix a race in hlist_nulls_for_each_entry_rcu macro | From | Eric Dumazet <> | Date | Tue, 21 May 2013 06:37:30 -0700 |
| |
On Tue, 2013-05-21 at 05:09 -0700, Paul E. McKenney wrote: > > > > -#define hlist_nulls_first_rcu(head) \ > > - (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > +#define hlist_nulls_first_rcu(head) \ > > + (*((struct hlist_nulls_node __rcu __force **) \ > > + &((volatile typeof(*head) *)head)->first)) > > Why not use ACCESS_ONCE() or (better) rcu_dereference_raw() here? >
+1
Very good catch Roman !
Thanks !
| |