lkml.org 
[lkml]   [2013]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[Suggestion] mm/bootmem.c: need return failure code when BUG() neither CONFIG_BUG nor HAVE_ARCH_BUG is defined.
Hello Maintainers:

If neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, the BUG() will
defined as empty (e.g. randconfig with MMU for arm s5pv210)

As a function, it need return an error code to upper caller, but excuse
me, I can not find the suitable error code for return (it seems only
'return -1' is not suitable).

Please help check, thanks.


356 static int __init mark_bootmem(unsigned long start, unsigned long end,
357 int reserve, int flags)
358 {
359 unsigned long pos;
360 bootmem_data_t *bdata;
361
362 pos = start;
363 list_for_each_entry(bdata, &bdata_list, list) {
364 int err;
365 unsigned long max;
366
367 if (pos < bdata->node_min_pfn ||
368 pos >= bdata->node_low_pfn) {
369 BUG_ON(pos != start);
370 continue;
371 }
372
373 max = min(bdata->node_low_pfn, end);
374
375 err = mark_bootmem_node(bdata, pos, max, reserve, flags);
376 if (reserve && err) {
377 mark_bootmem(start, pos, 0, 0);
378 return err;
379 }
380
381 if (max == end)
382 return 0;
383 pos = bdata->node_low_pfn;
384 }
385 BUG();
386 }



Thanks.
--
Chen Gang

Asianux Corporation


\
 
 \ /
  Last update: 2013-05-20 11:01    [W:0.032 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site