lkml.org 
[lkml]   [2013]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup

On Sun, 19 May 2013, Francois Romieu wrote:

> Which one ?
> - share it through the kernel or with userspace
> - personal choice .c split

It is obviously not the former. I think that in general constant and
other definitions (in their majority) should be in a header file. I
definitely like this way better.

Perhaps in this particular case my patch is a bit of an overkill as the
code lines aren't that many. If the consensus is in this direction i'll
revert this part of the series.

> I don't mind the later even if it does not exactly apply to a
> WIP driver. I'd still avoid future copycat followers though.

This isn't WIP anymore as the W(ork) part is missing. After so many quiet
years i assume the experimental tag should be removed.

> The rtl8150.h file is created in patch #2. This is patch #1.
>
> So...

So first apply patch #1 and then patch #2.

However, if it is required for the driver to be in build-able form after
applying any single patch i'll coalesce #1 and #2 before next submission.


David?


Petko


\
 
 \ /
  Last update: 2013-05-20 09:41    [W:0.073 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site