Messages in this thread | | | Date | Mon, 20 May 2013 13:47:14 +0200 | Subject | Re: [PATCH v3] pinctrl: samsung: fix suspend/resume functionality | From | Linus Walleij <> |
| |
On Fri, May 17, 2013 at 6:33 AM, Doug Anderson <dianders@chromium.org> wrote:
> The GPIO states need to be restored after s2r and this is not currently > supported in the pinctrl driver. This patch saves the gpio states before > suspend and restores them after resume. > > Saving and restoring is done very early using syscore_ops and must > happen before pins are released from their powerdown state. > > Patch originally from Prathyush K <prathyush.k@samsung.com> but > rewritten by Doug Anderson <dianders@chromium.org>. > > Signed-off-by: Prathyush K <prathyush.k@samsung.com> > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > Changes in v3: > - Skip save and restore for banks with no powerdown config. > > Changes in v2: > - Now uses sycore_ops to make sure we're early enough. > - Try to handle two CON registers better. > - Should handle s3c24xx better as per Heiko. > - Simpler code; no longer tries to avoid glitching lines since > we _think_ all current SoCs should have pins in power down state > when the restore is called. > - Dropped eint patch for now; Tomasz will post his version.
Looks good to me. Acked-by: Linus Walleij <linus.walleij@linaro.org>
How are you going to merge this?
Samsung tree?
My pinctrl development tree?
Or my fixes tree, if it's a regression for v3.10?
Yours, Linus Walleij
| |