lkml.org 
[lkml]   [2013]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 093/115] 3c59x: fix freeing nonexistent resource on driver unload
    Date
    3.5.7.13 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

    commit c81400be716aa4c76f6ebf339ba94358dbbf6da6 upstream.

    When unloading the driver that drives an EISA board, a message similar to the
    following one is displayed:

    Trying to free nonexistent resource <0000000000013000-000000000001301f>

    Then an user is unable to reload the driver because the resource it requested in
    the previous load hasn't been freed. This happens most probably due to a typo in
    vortex_eisa_remove() which calls release_region() with 'dev->base_addr' instead
    of 'edev->base_addr'...

    Reported-by: Matthew Whitehead <tedheadster@gmail.com>
    Tested-by: Matthew Whitehead <tedheadster@gmail.com>
    Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/ethernet/3com/3c59x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c
    index e463d10..ccfc86f 100644
    --- a/drivers/net/ethernet/3com/3c59x.c
    +++ b/drivers/net/ethernet/3com/3c59x.c
    @@ -951,7 +951,7 @@ static int __devexit vortex_eisa_remove(struct device *device)

    unregister_netdev(dev);
    iowrite16(TotalReset|0x14, ioaddr + EL3_CMD);
    - release_region(dev->base_addr, VORTEX_TOTAL_SIZE);
    + release_region(edev->base_addr, VORTEX_TOTAL_SIZE);

    free_netdev(dev);
    return 0;
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-05-20 14:01    [W:5.948 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site