lkml.org 
[lkml]   [2013]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL v2] MFD: Fixes due for the v3.10 -rc:s
On Fri, May 17, 2013 at 10:25:10AM +0200, Linus Walleij wrote:
> On Fri, May 17, 2013 at 9:51 AM, Fabio Baltieri
> <fabio.baltieri@linaro.org> wrote:
> > Hello Samuel,
> (...)
> > The last two:
> >
> > mfd: ab8500-sysctrl: Set sysctrl_dev during probe
> > mfd: ab8500-sysctrl: Let sysctrl driver work without pdata
> >
> > are actually fixes for bugs introduced in this merge window that
> > inhibited the ab8500-sysctl driver as a consequence. Would you
> > reconsider pulling just those?
>
> A good way to make sure that patches fixing regressions are applied
> to the -rc series is to indicate in the commit message or even the
> heading that it fixes a regression.
>
> I usually try to begin such commits with the text:
>
> this patch fixes a regression caused by change 018745435
> "foo: fix bar"...
>
> Then copying in some crash dump text never hurts :-)
>
> It makes it very easy for us as subsystem maintainers to pick
> regression fixes.

Right, I actually pointed to the culprit commit (applied during the
merge window) in the message, but I'll try to be more direct next time.
I also agree on the crash dump, but unfortunately this one was failing
silently. :-)

Thanks for the tip!
Fabio

--
Fabio Baltieri


\
 
 \ /
  Last update: 2013-05-17 11:21    [W:0.070 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site