Messages in this thread | | | Date | Fri, 17 May 2013 20:54:45 +0200 | From | Oliver Schinagl <> | Subject | Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses |
| |
On 05/17/13 15:45, Arnd Bergmann wrote: > On Friday 17 May 2013 15:35:43 Oliver Schinagl wrote: >> +static struct bin_attribute sid_bin_attr = { >> + .attr = { >> + .name = "key", >> + .mode = S_IRUGO, >> + }, >> + .size = SUNXI_SID_SIZE, >> + .read = sid_read, >> +}; > > I believe all the other drivers in drivers/misc/eeprom use "eeprom" > as the name for the attribute, so using "key" here is a bit inconsistent. > > Can you change that? Changed, will wait for more feedback and then use that in the final version.
Should there also be a symlink elsewhere in /sys? Just curious is all. > > Arnd >
| |