Messages in this thread | | | Subject | Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument | From | Joe Perches <> | Date | Fri, 17 May 2013 10:58:20 -0700 |
| |
On Fri, 2013-05-17 at 20:50 +0300, Leon Romanovsky wrote: > On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > > On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote: > >> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c [] > >> @@ -121,7 +121,7 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata( [] > >> - pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > >> + pd = devm_kzalloc(dev, sizeof(struct sec_platform_data), GFP_KERNEL); > > How is that fixing anything ? > Technically you are right, this fix brings code to be align to common > code convention and allows to automatic tools correctly parse it.
Not really. Common coding convention is actually the original code.
from: Documentation/CodingStyle:
Chapter 14: Allocating memory [] The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
| |