Messages in this thread | | | Date | Fri, 17 May 2013 16:28:17 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 3/9] perf top: Get rid of *_threaded() functions |
| |
On Tue, May 14, 2013 at 11:09:01AM +0900, Namhyung Kim wrote: > From: Namhyung Kim <namhyung.kim@lge.com> > > Those _threaded() functions are needed to make hist tree handling > thread-safe, but AFAICS the only thing it does is forcing it to use > the intermediate 'collapsed' tree. It can be acheived by setting > sort__need_collapse to 1 in cmd_top() so no need to keep those > _threaded() variants. > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/builtin-top.c | 23 +++++++++++++---------- > tools/perf/util/hist.c | 44 ++++++-------------------------------------- > tools/perf/util/hist.h | 4 ---- > 3 files changed, 19 insertions(+), 52 deletions(-)
Acked-by: Jiri Olsa <jolsa@redhat.com>
jirka
| |