Messages in this thread | | | From | Prabhakar Lad <> | Date | Fri, 17 May 2013 10:23:16 +0530 | Subject | Re: [PATCH 2/5] net: davinci_emac: remove unwanted header inclusion and sort the alphabetically |
| |
Hi Sergei,
Thanks for the review.
On Fri, May 17, 2013 at 12:25 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 16-05-2013 11:30, Lad Prabhakar wrote: > >> From: Lad, Prabhakar <prabhakar.csengg@gmail.com> > > >> This patch removes unwanted header inclusion > > > Why are they unwanted? > The driver builds without this includes.
This is arguable, if I would have added a new driver with the only #includes which were required to build thats accepted. But when I remove unnecessary #includes from the existing drivers that's not acceptable ?
This applies to rest of the similar patches in the series.
>> and sorts them alphabetically > > > In the subject you typed "the" instead of "them". > Hmm carry forwarded this copy paste error every where will fix it in V2.
Regards, --Prabhakar Lad
| |