lkml.org 
[lkml]   [2013]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] ipmi: Improve error messages on failed irq enable
From
Date
On Thu, 2013-05-16 at 22:47 -0500, Corey Minyard wrote:
> On 05/16/2013 05:23 PM, Andy Lutomirski wrote:
> >
> > /* We got the flags from the SMI, now handle them. */
> > smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
> > - if (msg[2] != 0)
> > - dev_warn(smi_info->dev, "Could not enable interrupts"
> > - ", failed set, using polled mode.\n");
> > - else
> > + if (msg[2] != 0) {
> > + dev_warn(smi_info->dev,
> > + "Couldn't set irq info: %x.\n", msg[2]);
> > + dev_warn(smi_info->dev,
> > + "Maybe ok, but ipmi might run very slowly.\n");
> > + } else
> > Minor nit: it would be nice if these warnings were collapsed into a
> > single printk -- that would save me a whitelist entry of acceptable
> > KERN_WARNING messages :)
>
> Yeah, the trouble is that checkpatch will give a warning if you split a
> string
> between two lines or if a line is longer than 80 characters.

Hi Corey.

Yes it will and no it won't.

dev_<level>(struct device *, "some really really long format string that makes the line longer than 80 chars\n");

passes checkpatch without warning just fine.

I'd use something like:

dev_warn(smi_info->dev,
"Couldn't set irq info: %x - this may be OK, but ipmi might run very slowly\n",
msg[2]);




\
 
 \ /
  Last update: 2013-05-17 07:41    [W:0.041 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site