Messages in this thread | | | Date | Thu, 16 May 2013 00:01:30 -0400 | From | Greg KH <> | Subject | Re: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support |
| |
On Wed, May 15, 2013 at 03:02:29PM -0700, K. Y. Srinivasan wrote: > +/* > + * Retrieve the (sub) channel on which to send an outgoing request. > + * When a primary channel has multiple sub-channels, we choose a > + * channel whose VCPU binding is closest to the VCPU on which > + * this call is being made. > + */ > +struct vmbus_channel *get_outgoing_channel(struct vmbus_channel *primary)
That's a _very_ vague global symbol name you are adding to the kernel. Same goes for the other functions you are adding here, please fix that, and make them have the vmbus_ prefix, like everything else in this patch.
So, sorry, no ack here.
greg k-h
| |