lkml.org 
[lkml]   [2013]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support
On Wed, May 15, 2013 at 03:02:29PM -0700, K. Y. Srinivasan wrote:
> +/*
> + * Retrieve the (sub) channel on which to send an outgoing request.
> + * When a primary channel has multiple sub-channels, we choose a
> + * channel whose VCPU binding is closest to the VCPU on which
> + * this call is being made.
> + */
> +struct vmbus_channel *get_outgoing_channel(struct vmbus_channel *primary)

That's a _very_ vague global symbol name you are adding to the kernel.
Same goes for the other functions you are adding here, please fix that,
and make them have the vmbus_ prefix, like everything else in this
patch.

So, sorry, no ack here.

greg k-h


\
 
 \ /
  Last update: 2013-05-16 06:41    [W:0.116 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site