Messages in this thread | | | Date | Fri, 17 May 2013 01:37:39 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata |
| |
Hi Prabhakar,
Thanks for the patch!
On Wed, May 15, 2013 at 05:27:17PM +0530, Lad Prabhakar wrote: > diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c > index 65853ee..8cddcd0 100644 > --- a/drivers/media/i2c/ths7303.c > +++ b/drivers/media/i2c/ths7303.c > @@ -356,9 +356,7 @@ static int ths7303_setup(struct v4l2_subdev *sd) > int ret; > u8 mask; > > - state->stream_on = pdata->init_enable; > - > - mask = state->stream_on ? 0xff : 0xf8; > + mask = 0xf8;
You can assign mask in declaration. It'd be nice to have a human-readable name for the mask, too.
-- Kind regards,
Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
| |