Messages in this thread Patch in this message | | | Date | Thu, 16 May 2013 14:31:30 +0800 | From | dyoung@redhat ... | Subject | [PATCH] print sysfs attribute name when warning about bogus permissions |
| |
Make it obvious to see what attribute is using bogus permissions.
Signed-off-by: Dave Young <dyoung@redhat.com> Acked-by: Felipe Balbi <balbi@ti.com> --- drivers/base/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
--- linux-2.6.orig/drivers/base/core.c +++ linux-2.6/drivers/base/core.c @@ -572,9 +572,11 @@ int device_create_file(struct device *de if (dev) { WARN(((attr->attr.mode & S_IWUGO) && !attr->store), - "Write permission without 'store'\n"); + "Attribute %s: write permission without 'store'\n", + attr->attr.name); WARN(((attr->attr.mode & S_IRUGO) && !attr->show), - "Read permission without 'show'\n"); + "Attribute %s: read permission without 'show'\n", + attr->attr.name); error = sysfs_create_file(&dev->kobj, &attr->attr); }
| |