lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
> Asias He <asias@redhat.com> writes:
> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >
> > This patch fixes this build failure.
> >
> > From Randy Dunlap:
> > '''
> > on x86_64:
> >
> > ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined!
> >
> > It needs to depend on NET since net/core/ provides that function.
> > '''
>
> Proper fix please.

--verbose please ;-)

Making VHOST_SCSI depends on NET looks weird but this is because vhost
core depends on it. A bunch of patches are cleaning this up. Since MST
wanted do the vhost.ko split up in 3.11, plus your WIP vringh work, so I
wanted the fix for 3.10 as minimum as possible.

Other users are using memcpy_fromiovec and friends outside net. It seems
a good idea to put it in a util library. e.g. crypto/algif_skcipher.c
which also depends on NET for it.

> Though I can't see why you thought this was a good idea. Nonetheless, I
> shan't highlight why: I have far too much respect for your intellects
> and abilities.
>
> No, don't thank me!

Interesting.

> Rusty.

--
Asias


\
 
 \ /
  Last update: 2013-05-16 04:21    [W:0.125 / U:4.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site