lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: ACPI fan driver: uninitialized variable when CONFIG_PM is not set
From
Date
Hi, Michel,

On Mon, 2013-04-29 at 05:32 -0700, Michel Lespinasse wrote:
> In the following code:
>
> static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long
> *state)
> {
> struct acpi_device *device = cdev->devdata;
> int result;
> int acpi_state;
>
> if (!device)
> return -EINVAL;
>
> result = acpi_bus_update_power(device->handle, &acpi_state);
> if (result)
> return result;
>
> *state = (acpi_state == ACPI_STATE_D3 ? 0 :
> (acpi_state == ACPI_STATE_D0 ? 1 : -1));
> return 0;
> }
>
> With CONFIG_PM not set, acpi_bus_update_power() returns 0 and does not
> initialize acpi_state. This results in acpi_state being used before
> initialization.
>
> (I found out by random chance, as I suppose people don't normally
> build without CONFIG_PM anymore ?)
>
> I'm not sure what a proper fix would be, so I'll just report this here
> and enable CONFIG_PM locally :)
>
thanks for your report.
please check if the following patch helps or not.
https://patchwork.kernel.org/patch/2574691/

thanks,
rui



\
 
 \ /
  Last update: 2013-05-16 03:21    [W:0.061 / U:2.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site