lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: r8169 on 3.8.13, 3.9.2, 3.10-rc1, was Re: [ 00/73] 3.8.13-stable review
From
From: David Miller <davem@davemloft.net>
Date: Wed, 15 May 2013 13:39:13 -0700 (PDT)

> From: Francois Romieu <romieu@fr.zoreil.com>
> Date: Wed, 15 May 2013 08:14:01 +0200
>
>> Ken Moffat <zarniwhoop@ntlworld.com> :
>> [...]
>>> Cc'ing to netdev because I don't think this has had a response, and
>>
>> A patch has been sent to netdev a few hours ago. It needs more work,
>> especially testing (hint, hint) as I don't have a proven test case yet.
>>
>> Please note:
>> - if you don't use a 8168evl (check your dmesg for the XID line emitted
>> by the r8169 driver), you are not the experiencing the same bug.
>> - if you don't enable Tx checksum offload (distro/vendor dependent though
>> disabled by default in the vanilla driver, see ethtool -k eth0,
>> ethtool -K eth0 tx on sg on)), you are not the experiencing the same
>> bug.
>> - if you are experiencing the same bug, 3.10-rc1 should work again
>> after reverting e5195c1f31f399289347e043d6abf3ffa80f0005
>>
>> If someone comes with a failing network capture and a working one, it will
>> save time. A 64 bytes (max) packet is not correctly transmitted.
>
> FWIW, I was about to submit the regression causing commit to -stable
> but now I'm going to hold off until we get the fix for it to Linus.

Oh, I see, someone merged it behind my back.

Well, guys, now do you see why I let patches cook in Linus's tree for a
week or two before I submit them to Linus?

It's so that bugs like this are less likely to propagate, and we find
them such problems and fix them before a change hits -stable and
therefore has an effect on an even larger number of users.

Please, use the networking -stable submission process. If you want a
patch merged, tell me, and I'll queue it up in patchwork.


\
 
 \ /
  Last update: 2013-05-16 01:41    [W:0.405 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site