Messages in this thread | | | Date | Wed, 15 May 2013 12:47:21 +0900 | Subject | Re: [PATCH 1/2] f2fs: fix inconsistency of block count during recovery | From | Namjae Jeon <> |
| |
> > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 3df43b4..9641534 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1492,6 +1492,8 @@ int recover_inode_page(struct f2fs_sb_info *sbi, > struct page *page) > new_ni = old_ni; > new_ni.ino = ino; > Hi. Jaegeuk.
I have a minor comment. > + if (!inc_valid_node_count(sbi, NULL, 1)) > + WARN_ON(1); How about change WARN_ON(!inc_valid_node_count(sbi, NULL, 1)); ?
Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com> Thanks. > set_node_addr(sbi, &new_ni, NEW_ADDR); > inc_valid_inode_count(sbi); > > -- > 1.8.1.3.566.gaa39828 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |