lkml.org 
[lkml]   [2013]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 3.9.0: panic during boot - kernel BUG at include/linux/gfp.h:323!
Hello,

On Tue, May 14, 2013 at 11:35:29AM +0800, Lingzhu Xiang wrote:
> On 05/06/2013 03:55 PM, CAI Qian wrote:
> >[ 0.928031] ------------[ cut here ]------------
> >[ 0.934231] kernel BUG at include/linux/gfp.h:323!
...
> >[ 1.662913] [<ffffffff812e3aa8>] alloc_cpumask_var_node+0x28/0x90
> >[ 1.671224] [<ffffffff81a0bdb3>] wq_numa_init+0x10d/0x1be
> >[ 1.686085] [<ffffffff81a0bec8>] init_workqueues+0x64/0x341

Does the following patch make the problem go away? The dynamic paths
should be safe as they are synchronized against CPU hot plug paths and
don't allocate anything on nodes w/o any CPUs.

Thanks.

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 4aa9f5b..232c1bb 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4895,7 +4895,8 @@ static void __init wq_numa_init(void)
BUG_ON(!tbl);

for_each_node(node)
- BUG_ON(!alloc_cpumask_var_node(&tbl[node], GFP_KERNEL, node));
+ BUG_ON(!alloc_cpumask_var_node(&tbl[node], GFP_KERNEL,
+ node_online(node) ? node : NUMA_NO_NODE));

for_each_possible_cpu(cpu) {
node = cpu_to_node(cpu);

\
 
 \ /
  Last update: 2013-05-14 21:21    [W:0.183 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site