lkml.org 
[lkml]   [2013]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:timers/urgent] tick: Don't invoke tick_nohz_stop_sched_tick( ) if the cpu is offline
    Commit-ID:  f7ea0fd639c2c48d3c61b6eec75362be290c6874
    Gitweb: http://git.kernel.org/tip/f7ea0fd639c2c48d3c61b6eec75362be290c6874
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Mon, 13 May 2013 21:40:27 +0200
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Tue, 14 May 2013 17:40:31 +0200

    tick: Don't invoke tick_nohz_stop_sched_tick() if the cpu is offline

    commit 5b39939a4 (nohz: Move ts->idle_calls incrementation into strict
    idle logic) moved code out of tick_nohz_stop_sched_tick() and missed
    to bail out when the cpu is offline. That's causing subsequent
    failures as an offline CPU is supposed to die and not to fiddle with
    nohz magic.

    Return false in can_stop_idle_tick() if the cpu is offline.

    Reported-and-tested-by: Jiri Kosina <jkosina@suse.cz>
    Reported-and-tested-by: Prarit Bhargava <prarit@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: x86@kernel.org
    Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1305132138160.2863@ionos
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    ---
    kernel/time/tick-sched.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
    index 0eed1db..0121421 100644
    --- a/kernel/time/tick-sched.c
    +++ b/kernel/time/tick-sched.c
    @@ -469,6 +469,7 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
    if (unlikely(!cpu_online(cpu))) {
    if (cpu == tick_do_timer_cpu)
    tick_do_timer_cpu = TICK_DO_TIMER_NONE;
    + return false;
    }

    if (unlikely(ts->nohz_mode == NOHZ_MODE_INACTIVE))

    \
     
     \ /
      Last update: 2013-05-14 19:01    [W:5.660 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site