Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 1/2] nohz: Select VIRT_CPU_ACCOUNTING_GEN from full dynticks config | Date | Mon, 13 May 2013 14:16:14 -0700 |
| |
Frederic Weisbecker <fweisbec@gmail.com> writes:
> Turn the full dynticks passive dependency on VIRT_CPU_ACCOUNTING_GEN > to an active one.
[...]
> @@ -329,7 +329,7 @@ config VIRT_CPU_ACCOUNTING_NATIVE > > config VIRT_CPU_ACCOUNTING_GEN > bool "Full dynticks CPU time accounting" > - depends on HAVE_CONTEXT_TRACKING && 64BIT > + depends on HAVE_CONTEXT_TRACKING && 64BIT && NO_HZ_FULL > select VIRT_CPU_ACCOUNTING > select CONTEXT_TRACKING > help
Existing 64-bit dependency is here...
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig > index 1ea2bba..a2ddd65 100644 > --- a/kernel/time/Kconfig > +++ b/kernel/time/Kconfig > @@ -104,11 +104,13 @@ config NO_HZ_FULL > depends on SMP > # RCU_USER_QS dependency > depends on HAVE_CONTEXT_TRACKING > - depends on VIRT_CPU_ACCOUNTING_GEN > + # VIRT_CPU_ACCOUNTING_GEN dependency > + depends on 64BIT
...and another one added here?
Is there a new 64-bit dependency in NO_HZ_FULL not covered by the one already in VIRT_CPU_ACCOUNTING_GEN? Or do you have reasons to be doubly paranoid about the non 64-bit usage? ;)
Kevin
| |