Messages in this thread | | | Date | Mon, 13 May 2013 22:15:25 +0530 | Subject | Re: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table | From | Viresh Kumar <> |
| |
On 13 May 2013 21:57, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 05/13/2013 06:57 AM, Viresh Kumar wrote: >> "Index" field of struct cpufreq_frequency_table was never index and isn't used >> at all by cpufreq core. And is only useful for cpufreq drivers for their >> personal use. >> >> Many people now a days blindly set it in ascending order with the assumption >> that core is using it for some work. >> >> This patch renames it to "data" as that's what its purpose it. All users of the >> same are fixed too. > >> diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c > >> -/* Frequency table index must be sequential starting at 0 */ >> +/* Frequency table data must be sequential starting at 0 */ > > I assume that comment is due to the assumption you're trying to remove. > Should the comment be removed/corrected now? Perhaps the .data field > isn't even needed any more in this driver?
Probably removed and that too in a separate patch.
| |