lkml.org 
[lkml]   [2013]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table
    On 05/13/2013 06:57 AM, Viresh Kumar wrote:
    > "Index" field of struct cpufreq_frequency_table was never index and isn't used
    > at all by cpufreq core. And is only useful for cpufreq drivers for their
    > personal use.
    >
    > Many people now a days blindly set it in ascending order with the assumption
    > that core is using it for some work.
    >
    > This patch renames it to "data" as that's what its purpose it. All users of the
    > same are fixed too.

    > diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c

    > -/* Frequency table index must be sequential starting at 0 */
    > +/* Frequency table data must be sequential starting at 0 */

    I assume that comment is due to the assumption you're trying to remove.
    Should the comment be removed/corrected now? Perhaps the .data field
    isn't even needed any more in this driver?

    > static struct cpufreq_frequency_table freq_table[] = {
    > { 0, 216000 },
    > { 1, 312000 },



    \
     
     \ /
      Last update: 2013-05-13 19:01    [W:7.114 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site