Messages in this thread | | | Subject | Re: [RFC PATCHv3 1/6] arm: Initial TI-Nspire support | From | Daniel Tang <> | Date | Sun, 12 May 2013 19:22:45 +1000 |
| |
On 12/05/2013, at 7:06 PM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Sun, May 12, 2013 at 02:22:56PM +1000, Daniel Tang wrote: >> >> + .bpp = 8, >> + .grayscale = 1 >> +}; > > Still no capabilities in the above - how does the CLCD controller know > which of BGR or RGB output and which format these panels support? > > Each entry needs a .caps = CLCD_CAP_xxx | CLCD_CAP_xxx listing the > formats supported there. > > Unless panels and the board have a .caps entry, the caps system won't > be used.
Fair enough.
> >> +static struct clcd_board nspire_clcd_data = { >> + .name = "LCD", >> + .caps = CLCD_CAP_ALL, > > Your board has logic to support the RGB444/BGR444 mode? If not, setting > CLCD_CAP_ALL is incorrect.
I believe the grayscale panel supports the xGx444 modes - unsure about the colour one. Since I'm using the same struct clcd_board for both panels, I thought I'd just set caps to work with both to simplify.
Should I set board caps to panel caps on setup?
Cheers,
| |