lkml.org 
[lkml]   [2013]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250
From
Jingoo,

On Sat, May 11, 2013 at 1:09 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> Add pin state information for DP HPD support that requires
> pin configuration support using pinctrl interface.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Tested on Exynos5250
>
> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index d1650fb..e9cdee3 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -553,6 +553,13 @@
> samsung,pin-pud = <0>;
> samaung,pin-drv = <0>;
> };
> +
> + dp_hpd: dp_hpd {
> + samsung,pins = "gpx0-7";
> + samsung,pin-function = <3>;
> + samsung,pin-pud = <0>;
> + samaung,pin-drv = <0>;
> + };
> };
>
> pinctrl@13400000 {
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 3e0c792..d53ea34 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -224,6 +224,9 @@
> samsung,color-depth = <1>;
> samsung,link-rate = <0x0a>;
> samsung,lane-count = <4>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&dp_hpd>;

I was going to suggest moving this to exynos5250.dtsi but then
realized that I saw a board recently that used a non-standard HPD pin
recently! ...so keeping it in the board file (like you've done) is
good.

...so looks good to me.

Reviewed-by: Doug Anderson <dianders@chromium.org>


\
 
 \ /
  Last update: 2013-05-12 00:21    [W:0.069 / U:1.092 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site