lkml.org 
[lkml]   [2013]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 3/8] pci: Add pci_hp_reset_slot
    From
    Date
    On Tue, 2013-05-07 at 20:57 -0600, Alex Williamson wrote:
    > Provide an interface to get to hotplug controller reset_slot callback
    >
    > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    > ---
    > drivers/pci/hotplug/pci_hotplug_core.c | 24 ++++++++++++++++++++++++
    > include/linux/pci_hotplug.h | 8 ++++++++
    > 2 files changed, 32 insertions(+)
    >
    > diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
    > index 202f4a9..1d0fee4 100644
    > --- a/drivers/pci/hotplug/pci_hotplug_core.c
    > +++ b/drivers/pci/hotplug/pci_hotplug_core.c
    > @@ -537,6 +537,29 @@ int __must_check pci_hp_change_slot_info(struct hotplug_slot *hotplug,
    > return 0;
    > }
    >
    > +/**
    > + * pci_hp_reset_slot - reset slot
    > + *
    > + * @hotplug: pointer to hotplug slot to reset
    > + * @probe: reset slot (0) or just probe
    > + *
    > + * Returns 0 if successful, anything else for an error.
    > + */
    > +int pci_hp_reset_slot(struct hotplug_slot *hotplug, int probe)
    > +{
    > + int result = -ENOTTY;
    > +
    > + if (!hotplug || !try_module_get(hotplug->ops->owner))
    > + return result;
    > +
    > + if (hotplug->ops->reset_slot)
    > + result = hotplug->ops->reset_slot(hotplug, probe);
    > +
    > + module_put(hotplug->ops->owner);
    > +
    > + return result;
    > +}
    > +
    > static int __init pci_hotplug_init (void)
    > {
    > int result;
    > @@ -570,3 +593,4 @@ MODULE_PARM_DESC(debug, "Debugging mode enabled or not");
    > EXPORT_SYMBOL_GPL(__pci_hp_register);
    > EXPORT_SYMBOL_GPL(pci_hp_deregister);
    > EXPORT_SYMBOL_GPL(pci_hp_change_slot_info);
    > +EXPORT_SYMBOL_GPL(pci_hp_reset_slot);
    > diff --git a/include/linux/pci_hotplug.h b/include/linux/pci_hotplug.h
    > index 0d3a604..d771cee 100644
    > --- a/include/linux/pci_hotplug.h
    > +++ b/include/linux/pci_hotplug.h
    > @@ -135,6 +135,14 @@ extern int __pci_hp_register(struct hotplug_slot *slot, struct pci_bus *pbus,
    > extern int pci_hp_deregister(struct hotplug_slot *slot);
    > extern int __must_check pci_hp_change_slot_info (struct hotplug_slot *slot,
    > struct hotplug_slot_info *info);
    > +#ifdef CONFIG_HOTPLUG_PCI
    > +int pci_hp_reset_slot(struct hotplug_slot *slot, int probe);
    > +#else
    > +static inline int pci_hp_reset_slot(struct hotplug_slot *slot, int probe)
    > +{
    > + return -ENOTTY;
    > +}
    > +#endif
    >
    > /* use a define to avoid include chaining to get THIS_MODULE & friends */
    > #define pci_hp_register(slot, pbus, devnr, name) \
    >

    There's a bug here when CONFIG_HOTPLUG_PCI=m. I'll fix and repost.
    self NAK. Thanks,

    Alex



    \
     
     \ /
      Last update: 2013-05-11 00:01    [W:3.823 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site