Messages in this thread | | | Date | Fri, 10 May 2013 10:57:37 +0200 | From | John Crispin <> | Subject | Re: [RFC 40/42] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource |
| |
On 10/05/13 10:17, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang<wsa@the-dreams.de>
Acked-by: John Crispin <blogic@openwrt.org>
> --- > arch/mips/lantiq/xway/gptu.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c > index 9861c86..26226f0 100644 > --- a/arch/mips/lantiq/xway/gptu.c > +++ b/arch/mips/lantiq/xway/gptu.c > @@ -143,13 +143,8 @@ static int gptu_probe(struct platform_device *pdev) > return -EINVAL; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get resource\n"); > - return -ENOMEM; > - } > - > /* remap gptu register range */ > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > gptu_membase = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(gptu_membase)) > return PTR_ERR(gptu_membase);
| |