Messages in this thread | | | Date | Wed, 1 May 2013 13:43:26 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 9/9] rsxx: Disallows DMA transfer during format. |
| |
On Tue, Apr 30 2013, Philip J. Kelleher wrote: > From: Philip J Kelleher <pjk1939@linux.vnet.ibm.com> > > Verifies the card is not formatting before DMAs are > transferred. > > Signed-off-by: Philip J Kelleher <pjk1939@linux.vnet.ibm.com> > ------------------------------------------------------------------------------- > > > diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/dma.c linux-block/drivers/block/rsxx/dma.c > --- linux-block-vanilla/drivers/block/rsxx/dma.c 2013-04-29 16:06:49.997249172 -0500 > +++ linux-block/drivers/block/rsxx/dma.c 2013-04-29 16:10:46.960184429 -0500 > @@ -721,7 +721,8 @@ int rsxx_dma_queue_bio(struct rsxx_cardi > } > } > > - if (unlikely(card->halt)) > + if (unlikely(card->halt) || > + unlikely(card->state == CARD_STATE_FORMATTING)) > goto bvec_err; > > for (i = 0; i < card->n_targets; i++) {
What happens if card->state is set to formatting right after this check?
-- Jens Axboe
| |