Messages in this thread | | | Date | Wed, 1 May 2013 21:19:23 -0500 | From | Robin Holt <> | Subject | Re: [PATCH -v7 0/11] Shutdown from reboot_cpuid without stopping other cpus. |
| |
On Thu, May 02, 2013 at 12:13:47AM +0100, Russell King - ARM Linux wrote: > On Wed, May 01, 2013 at 12:06:40PM -0500, Robin Holt wrote: > > Andrew, Please do _NOT_ take this patch series yet. I am sending this > > to you because you had comments on my -v6 submission. > > Another reason for not applying this is that I believe it wilfully breaks > a bunch of ARM platforms - such as removing the 'g' reboot mode (for gpio > based reboot on PXA), and removing the 's' reboot mode off a bunch of ARM > platforms which have no way to do a hard reboot. > > What scares me is that this is revision 7 of this patch set and this is > the first it's been noticed on ARM... Maybe this patch set didn't touch > ARM previously?
It started with a simple add a CONFIG_ value which eliminated the calls to offline all cpus. That expanded to the migrate to cpu 0. Then the suggestion was to make a kernel parameter for selecting which cpu to migrate to. That led to discovering x86's reboot=s## parameter. That led to move that to generic code, which led to resolving the conflict between arm, unicore32, and x86 and therefore, this patch series.
If I had my preference, I would go back to -v2, polish it a bit, and resubmit. It just put the migrate_to_boot_cpu in kernel/sys.c, put the calls in place, and continued with shutdown.
Second choice would be -v4 which added a reboot_cpu (actually, then it was reboot_cpuid, but I would make it reboot_cpu) core_param, fixed the x86 reboot=s## handling to handle more than the first 100 cpus and also the documented smp## syntax. I would not twiddle with unicore32 or arm.
Bottom line, the first 5 patches in this series are what I really care about. They get me the ability to shut my machine down in under 15 minutes. The rest is just stuff I am doing to gain acceptance for those.
Robin
| |