lkml.org 
[lkml]   [2013]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] swap: redirty page if page write fails on swap file
    Ping, ;-)
    On 04/18/2013 08:13 AM, Simon Jeons wrote:
    > Hi Jerome,
    > On 04/17/2013 08:11 PM, Jerome Marchand wrote:
    >> Since commit 62c230b, swap_writepage() calls direct_IO on swap files.
    >> However, in that case page isn't redirtied if I/O fails, and is
    >> therefore
    >> handled afterwards as if it has been successfully written to the swap
    >> file, leading to memory corruption when the page is eventually swapped
    >> back in.
    >> This patch sets the page dirty when direct_IO() fails. It fixes a memory
    >
    > If swapfile has related page cache which cached swapfile in memory? It
    > is not necessary, correct?
    >
    >> corruption that happened while using swap-over-NFS.
    >>
    >> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
    >> ---
    >> mm/page_io.c | 2 ++
    >> 1 files changed, 2 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/mm/page_io.c b/mm/page_io.c
    >> index 78eee32..04ca00d 100644
    >> --- a/mm/page_io.c
    >> +++ b/mm/page_io.c
    >> @@ -222,6 +222,8 @@ int swap_writepage(struct page *page, struct
    >> writeback_control *wbc)
    >> if (ret == PAGE_SIZE) {
    >> count_vm_event(PSWPOUT);
    >> ret = 0;
    >> + } else {
    >> + set_page_dirty(page);
    >> }
    >> return ret;
    >> }
    >>
    >> --
    >> To unsubscribe, send a message with 'unsubscribe linux-mm' in
    >> the body to majordomo@kvack.org. For more info on Linux MM,
    >> see: http://www.linux-mm.org/ .
    >> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
    >



    \
     
     \ /
      Last update: 2013-05-01 10:01    [W:4.898 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site