Messages in this thread | | | Date | Wed, 1 May 2013 18:42:46 +0200 | From | Oleg Nesterov <> | Subject | Re: [systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM |
| |
On 04/30, Colin Walters wrote: > > On Tue, 2013-04-30 at 19:47 +0200, Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Apr 30, 2013 at 01:12:19PM -0400, Colin Walters wrote: > > > This patch makes systemd-coredump handle processes that have > > > whitespace in their COMM fields. > > > > > > fs/coredump.c when given %e (as systemd-coredump uses), will end up > > > joining the process arguments into a string (along with the other > > > fields), then will split the entire thing up on whitespace, and use > > > it as the arguments to the coredump pipe handler. > > > --- > > That's a workaround for a bug in the kernel. I think it makes sense, but > > it'd be nice to fix the kernel too.
I wouldn't say this is bug... at least this is expected.
Sure, it is possible to rewrite format_corename/argv_split interaction, but this is a bit painful and I am not sure it worth the trouble.
> To do what though? Add a new coredump format specifier that gives you > a string-escaped version as one argument? That'd probably make sense,
Or, perhaps, we can simply change cn_escape() to do s/space/something/ unconditionally (currently it only does s'/'!'). But this is a user- visible change.
Oleg.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |