Messages in this thread | | | Subject | Re: [PATCH 2/2] hfsplus: add printk to log allocation failure in hfs_find_init() | From | Joe Perches <> | Date | Sun, 07 Apr 2013 15:00:19 -0700 |
| |
On Mon, 2013-04-08 at 01:21 +0400, Alexey Khoroshilov wrote: > Add printk to log allocation failure in hfs_find_init(), > "so that there is a sign in dmesg when the error condition is triggered". > (per Hin-Tak Leung request)
Not needed. There already is a generic dump_stack on all allocation failures without __GFP_NOWARN.
> diff --git a/fs/hfsplus/bfind.c b/fs/hfsplus/bfind.c [] > @@ -18,8 +18,10 @@ int hfs_find_init(struct hfs_btree *tree, struct hfs_find_data *fd)
> + if (!ptr) { > + printk(KERN_ERR "hfs: allocation failed in hfs_find_init()\n"); > return -ENOMEM;
| |