lkml.org 
[lkml]   [2013]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v7 15/21] sched: pull all tasks from source group
On 04/04/2013 01:59 PM, Namhyung Kim wrote:
>> > - if (capacity && rq->nr_running == 1 && wl > env->imbalance)
>> > + if (rq->nr_running == 0 ||
>> > + (!(env->flags & LBF_POWER_BAL) && capacity &&
>> > + rq->nr_running == 1 && wl > env->imbalance))
> Just out of curious.
>
> In load_balance(), we only move normal tasks, right?
>
> Then shouldn't it check rq->cfs.h_nr_running rather than rq->nr_running?

Yes, it seems so.
What's your opinion of this, Peter?

--
Thanks
Alex


\
 
 \ /
  Last update: 2013-04-06 14:41    [W:0.082 / U:20.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site